Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use runs-on for replay-verify workflows #14846

Closed
wants to merge 1 commit into from
Closed

use runs-on for replay-verify workflows #14846

wants to merge 1 commit into from

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Oct 2, 2024 •
edited
Loading

Description

Update the the replay-verify and module-verify workflows to use runs-on instead of the high-perf-with-local-ssd runners

How Has This Been Tested?

Ran the workflows manually

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Oct 2, 2024 •
edited
Loading

⏱️ 2h 44m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
test-verify-modules / module-verify 40m 🟥 🟥 
rust-cargo-deny 22m 🟩 🟩 🟩 🟩 🟩 (+7 more)
test-verify-modules / module-verify 20m 🟥 
verify-modules-testnet / module-verify 20m 🟥 
check-dynamic-deps 14m 🟩 🟩 🟩 🟩 🟩 (+7 more)
verify-modules-mainnet / module-verify 6m 🟩 
general-lints 6m 🟩 🟩 🟩 🟩 🟩 (+7 more)
semgrep/ci 6m 🟩 🟩 🟩 🟩 🟩 (+7 more)
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+7 more)
test-verify-modules / module-verify 2m ⬜ 
rust-move-tests 2m 🟩 
determine-test-metadata 2m 🟩 🟩 🟩 🟩 🟩 (+10 more)
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 
rust-move-tests 2m 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@aluon aluon force-pushed the aluon/replay-verify-runs-on branch 10 times, most recently from c7e78f7 to 81a4b59 Compare October 4, 2024 00:21
@aluon aluon force-pushed the aluon/replay-verify-runs-on branch from 81a4b59 to aa98f4f Compare October 4, 2024 00:24
@aluon aluon closed this Nov 15, 2024
@aluon aluon deleted the aluon/replay-verify-runs-on branch November 15, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aluon